Integrate class cache #3270
Open
Integrate class cache #3270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
apmoriarty
commented
Nov 10, 2025
apmoriarty
commented
- TypeFactory now uses a CaffeineCache
- Document, Attributes, Content use a ThreadLocal Caffeine cache found in the Attribute class
- Updated DocumentSerializationIT for better coverage
…of the ClassCache TypeFactory now uses a CaffeineCache
jschmidt10
reviewed
Nov 14, 2025
warehouse/query-core/src/main/java/datawave/query/attributes/Content.java
Outdated
Show resolved
Hide resolved
jschmidt10
reviewed
Nov 14, 2025
warehouse/query-core/src/main/java/datawave/query/attributes/Content.java
Outdated
Show resolved
Hide resolved
jschmidt10
reviewed
Nov 14, 2025
| protected long sizeInBytes = Long.MIN_VALUE; | ||
|
|
||
| // used by Document, Attributes and TypeAttribute | ||
| protected static final ThreadLocal<ClassCache> classCache = ThreadLocal.withInitial(CaffeineClassCache::new); |
Collaborator
There was a problem hiding this comment.
Just curious why its thread local. Off the top of my head it sounds like it'd be better to share across all threads since we're still gonna end up doing reflection on each thread. Is it to remove contention?
Collaborator
Author
There was a problem hiding this comment.
Correct. Even though the Caffeine cache won out on performance there was still a lot of contention in an environment with lots of threads. Making this ThreadLocal improved the time to parse each document and reduced the overall wall clock time.
jschmidt10
approved these changes
Nov 17, 2025
lbschanno
approved these changes
Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.