Ingest supports writing bitset index keys #3384
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
apmoriarty
commented
Jan 16, 2026
apmoriarty
commented
- ingest supports writing bitset global index keys
- add ability to suppress standard global index keys
Add ability to disable writing standard shard index keys
Comment on lines
+397
to
+401
| tableName = conf.get(SHARD_BITSET_INDEX_TABLE_NAME, null); | ||
| if (null != tableName) { | ||
| tableNames.add(tableName); | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
only add this if enabled
Collaborator
There was a problem hiding this comment.
I see that isn't the previous pattern of the method, so feel free to take it or leave it
| String shardId = shard.substring(underscoreIndex + 1); | ||
| int offset = Integer.parseInt(shardId); | ||
| BitSet bitset = new BitSet(); | ||
| bitset.set(offset); |
Collaborator
There was a problem hiding this comment.
This will cause the underlying BitSet to be a dynamic size. This may or may not be a problem, just noting it here in case its relevant where the BitSet come together for different Values
|
|
||
| @Test | ||
| public void testSimpleReverseIndexWithBitsetIndex() { | ||
|
|
|
|
||
| @Test | ||
| public void testMaskedSimpleReverseIndexWithBitsetIndex() { | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.