initial prometheus integration for metrics and health #1170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfkoehler
commented
Aug 17, 2025
|
|
||
| Namespace.bind("MetricsManager", manager); | ||
| try (Response response = health.clusterAgents()) { | ||
| try (Response response = health.generateJsonResponse(results)) { |
Collaborator
Author
There was a problem hiding this comment.
This changes the intent of the test. Need to revert and correct the test
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
| } catch (Exception e) { | ||
| logger.warn("Could not retrieve metrics", e); | ||
| return Response.serverError().entity("Could not retrieve metrics: " + e.getMessage()).build(); |
Check warning
Code scanning / CodeQL
Information exposure through an error message Medium
cfkoehler
force-pushed
the
prometheus-dropwizard
branch
from
cf4ceff to
68009c2
Compare
Collaborator
|
I like this more than #1201 but it's more invasive. Can we keep this around for a bit to use as a reference? This could help if circle back and look into custom metrics. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.