gRPC exceptions are passed as args to RuntimeException #1230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
memny
approved these changes
Nov 21, 2025
| return pool.borrowObject(); | ||
| } catch (Exception e) { | ||
| throw new PoolException(String.format("Unable to borrow channel from pool: %s", e.getMessage())); | ||
| throw new PoolException(String.format("Unable to borrow channel from pool: %s", e.getMessage()), e); |
Collaborator
There was a problem hiding this comment.
i know not everyone agrees with me but i always follow this pattern.
Collaborator
There was a problem hiding this comment.
@rupert-griffin What @memny is getting at is that it might be best to include the exception message in all the throws in ServiceException like it is done here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.