8586 Correctly decompile 1 indexing for globals #8587
+132
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aidan-wallace-j12
force-pushed
the
oneOffset
branch
2 times, most recently
from
141df0c to
3c7af07
Compare
| /// \param multiplier will hold the biggest constant multiplier or 0, if no multiplier is present | ||
| /// \param maxLevel is the maximum depth to search in the tree | ||
| /// \return the sum of all constants in the additive expression | ||
| int8 ActionConstantPtr::getConstOffsetBack(Varnode *vn,int8 &multiplier,int4 maxLevel) |
There was a problem hiding this comment.
This is a direct copy and paste from RulePtrsubUndo. I'm not versed enough with the codebase to know where the function should get moved to in order to be shared between the two, and didn't want to introduce a dependency from one to the other where it shouldn't be
ryanmkurtz
added
Feature: Decompiler
Status: Triage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first draft of a solution to #8586. There are almost certainly some improvements that need to be made to code organization (first time contributor), but it solves most cases of global arrays with 1-indexing.
Some improvements can be made to recognized arrays within structs, and further levels of nesting, but this was a massive improvement on my current project. Cross-refs work correctly and drastically improves decompile as shown in #8586.