decompiler: fix INT_LEFT for constant bitshift by 0 and varnodes > 8 #8706
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes NationalSecurityAgency#8705 In case of a 0-bitshift, the mask computation was performing a 64-bit shift, assuming the result will be 0. However, such a bitshift is undefined and will be equal to a NOP on some architectures. This is fixed by explicitly checking for a shift-amount of 0.
ryanmkurtz
added
Feature: Decompiler
Status: Triage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8705
In case of a 0-bitshift, the mask computation was performing a 64-bit shift, assuming the result will be 0. However, such a bitshift is undefined and will be equal to a NOP on some architectures.
This is fixed by explicitly checking for a shift-amount of 0.