decompiler: fix bit extractions with RuleShiftAnd and RuleShiftCompare #8718
+1
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes NationalSecurityAgency#8717 RuleShiftAnd previously replaced the AND opcode with COPY. This, however doesn't update the NZMask of the Varnode. As a result, following rules may assume the NZMask after the AND operation also applies to the Varnode being copied. In combination with RuleShiftCompare, an expression of the form (a & bitmask) >> const != 0, wrongfully is reduced to a != 0. Instead of replacing the AND with COPY, we now replace the input of the shift operation instead. This way, future rules will see the correct NZMask.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8717
RuleShiftAnd previously replaced the AND opcode with COPY. This, however doesn't update the NZMask of the Varnode. As a result, following rules may assume the NZMask after the AND operation also applies to the Varnode being copied.
In combination with RuleShiftCompare, an expression of the form (a & bitmask) >> const != 0, wrongfully is reduced to a != 0. Instead of replacing the AND with COPY, we now replace the input of the shift operation instead. This way, future rules will see the correct NZMask.