Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat #666: add selective ignoreAttributes by pattern or callback #668

Merged
merged 2 commits into from
Sep 1, 2024

Conversation

mav-rik
Copy link
Contributor

@mav-rik mav-rik commented Aug 21, 2024

Purpose / Goal

Introduce a new feature that allows to selectively ignore XML attributes during parsing or building, based on an array of strings, regular expressions, or a callback function. No breaking changes, the old values ignoreAttributes: true and ignoreAttributes: false are processed same way as before.

Implements Issue #666.

Type

  • Bug Fix
  • Refactoring / Technology upgrade
  • New Feature

@mav-rik
Copy link
Contributor Author

mav-rik commented Aug 21, 2024

@amitguptagwl I don't get those two codeclimate issues pointing to "Avoid deeply nested control flow statements."
It looks like those issues are not caused by my changes, those were there initially.

@coveralls
Copy link

Coverage Status

coverage: 98.212% (+0.04%) from 98.175%
when pulling 512f3f9 on mav-rik:master
into d40e29c on NaturalIntelligence:master.

@amitguptagwl amitguptagwl merged commit 98d8f47 into NaturalIntelligence:master Sep 1, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants