Skip to content

feat(mysql): Add mysql databases #453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 10, 2024
Merged

feat(mysql): Add mysql databases #453

merged 7 commits into from
Oct 10, 2024

Conversation

dusdjhyeon
Copy link
Contributor

@dusdjhyeon dusdjhyeon commented Sep 25, 2024 •
edited
Loading

Resource

  • mysql_databases
  • mysql_databases_test

DataSource

  • mysql_databases
  • mysql_databases_test

Docs

  • mysql_databases(resource)
  • mysql_databases(data-source)

@dusdjhyeon dusdjhyeon changed the title feat(mysql): dd mysql databases feat(mysql): Add mysql databases Sep 25, 2024
@dusdjhyeon dusdjhyeon marked this pull request as draft September 25, 2024 02:11
wonchulee
wonchulee reviewed Sep 25, 2024
View reviewed changes
@dusdjhyeon dusdjhyeon marked this pull request as ready for review October 4, 2024 08:11
wonchulee
wonchulee reviewed Oct 8, 2024
View reviewed changes
Copy link
Collaborator

@wonchulee wonchulee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

사소한 코멘트 몇 개 남겼습니다. 참고 부탁드립니다. terraform 리소스/데이터 소스 작성은 뚝딱뚝딱이군요! 굿 👍

@dusdjhyeon dusdjhyeon requested a review from wonchulee October 8, 2024 09:52
wonchulee
wonchulee approved these changes Oct 10, 2024
View reviewed changes
Copy link
Collaborator

@wonchulee wonchulee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다. 👍

@wonchulee wonchulee merged commit 74c847b into NaverCloudPlatform:main Oct 10, 2024
2 checks passed
@youngmn youngmn mentioned this pull request Nov 27, 2024
Closed
@youngmn youngmn mentioned this pull request Dec 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wonchulee wonchulee wonchulee approved these changes

@youngmn youngmn Awaiting requested review from youngmn youngmn is a code owner

Assignees
No one assigned
Labels
documentation FRAMEWORK new-data-source new-resource VPC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dusdjhyeon @wonchulee @youngmn