Skip to content

feat(vpc blockstorage): Add the ability to create a KVM hypervisor type #461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Oct 18, 2024

Conversation

youngmn
Copy link
Collaborator

@youngmn youngmn commented Oct 14, 2024

Description

  • Adds functionality to the resource to create a KVM hypervisor type Block Storage.
  • ncloud-sdk-go-v2 v1.6.22 update : Modify Block Storage response type.
  • Update Resource : ncloud_server, ncloud_block_storage, ncloud_block_storage_snapshot
  • SUPPORT VPC : ncloud_block_storage_snapshot

AccTest results

=== RUN   TestAccResourceNcloudBlockStorageSnapshot_vpc_basic
--- PASS: TestAccResourceNcloudBlockStorageSnapshot_vpc_basic (590.25s)
PASS
ok  	github.com/terraform-providers/terraform-provider-ncloud/internal/service/server	591.072s

=== RUN   TestAccResourceNcloudBlockStorage_vpc_basic
--- PASS: TestAccResourceNcloudBlockStorage_vpc_basic (458.35s)
=== RUN   TestAccResourceNcloudBlockStorage_vpc_kvm
--- PASS: TestAccResourceNcloudBlockStorage_vpc_kvm (412.56s)
=== RUN   TestAccResourceNcloudBlockStorage_vpc_ChangeServerInstance
--- PASS: TestAccResourceNcloudBlockStorage_vpc_ChangeServerInstance (488.74s)
=== RUN   TestAccResourceNcloudBlockStorage_vpc_size
--- PASS: TestAccResourceNcloudBlockStorage_vpc_size (920.66s)
PASS
ok  	github.com/terraform-providers/terraform-provider-ncloud/internal/service/server	2281.058s

Copy link
Collaborator

@wonchulee wonchulee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like a tough change with much to check, good job 👍.
I left a few minor comments, please check them out. In addition, it would be great if you could add the server using KVM and blockstorage example code separately from Xen.

Copy link
Collaborator

@wonchulee wonchulee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 수고하셨습니다.
example은 /examples/ 아래에 위치한 예제를 말씀드린 것이긴 했는데, Doc 업데이트해주신 것으로도 우선 충분하지 않을까 싶습니다.

@wonchulee wonchulee merged commit b5e567b into main Oct 18, 2024
4 checks passed
@wonchulee wonchulee deleted the feat/bstroage_kvm branch October 18, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants