优化代码编辑体验，仅在切换模式时同步文件 AST 信息 #188
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
BoBoooooo
reviewed
Jul 23, 2024
| if (view === 'dual') { | ||
| this.setActiveSidebarPanel(''); | ||
| this.toggleRightPanel(false); | ||
| this.toggleIsPreview(true); | ||
| workspace2editor(); | ||
| } else if (view === 'design') { | ||
| this.toggleIsPreview(false); |
There was a problem hiding this comment.
切回设计视图的时候，默认不激活 RightPanel，在用户点击画布节点的时候(use-dnd onClick)中可以自动激活下 RightPanel ?
BoBoooooo
reviewed
Jul 23, 2024
packages/core/src/factory.ts
Outdated
| designer: new Designer({ | ||
| workspace, | ||
| editor: editorState, |
There was a problem hiding this comment.
目前相当于存在 工作区文件和 IDE 文件两种文件，在切换的时候做一次 clear 文件再同步
考虑 API 兼容的话，从关系上是不是 editor 注入在 workspace 中合适一些
workspace >> editor >> designer，API 也可以默认走 workspace，原有的 setActiveFile/CRUD File 相关 API 可以内部判断设计器状态来抹平
例如单边使用的场景：纯使用可视化面板/纯使用 IDE，在最终提交代码的时候消费哪个 API ？
BoBoooooo
reviewed
Jul 23, 2024
| onCancel: () => {}, | ||
| }); | ||
| } | ||
| editorState.updateFile({ filename: path, code: value }); |
There was a problem hiding this comment.
此处直接更新，在 editor2workspace 的时候，如果是错误的代码，在 workspace 重新 addFile的时候会不会有问题（导致设计视图白屏）
There was a problem hiding this comment.
此处可以在切换模式的时候增加 ErrorBoundary-- 提示用户是否代码错误
There was a problem hiding this comment.
模式切换时增加了错误提示浮沉，如果文件错误，不会进行同步操作 
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature
code -> design:EditorState --snyc--> Workspacedesign -> code:Workspace --sync--> EditorState