Skip to content

Commit b8fab9d

Browse files
author
Shih-Hao Yeh
committed
Add some more traces for debugging
1 parent 35ba1d0 commit b8fab9d

File tree

1 file changed

+13
-4
lines changed

1 file changed

+13
-4
lines changed

evcache-core/src/main/java/com/netflix/evcache/pool/EVCacheClientUtil.java

+13-4
Original file line numberDiff line numberDiff line change
@@ -73,12 +73,20 @@ public EVCacheLatch add(EVCacheKey evcKey, final CachedData cd, Transcoder evcac
7373
if(fixMissing) {
7474
boolean status = f.get().booleanValue();
7575
if(!status) { // most common case
76-
if(firstStatus == null && !bypassAddOpt) {
77-
for(int i = 0; i < clients.length; i++) {
78-
latch.countDown();
76+
if(firstStatus == null) {
77+
if (log.isDebugEnabled()) log.debug("Add failed at first client. key: " + key + ", client : " + client);
78+
if(!bypassAddOpt) {
79+
if (log.isDebugEnabled()) log.debug("Short circuiting due to optimization!!");
80+
for (int i = 0; i < clients.length; i++) {
81+
latch.countDown();
82+
}
83+
return latch;
84+
}
85+
else {
86+
return fixup(client, clients, evcKey, timeToLive, policy);
7987
}
80-
return latch;
8188
} else {
89+
if (log.isDebugEnabled()) log.debug("Add failed after first client. key: " + key + ", client : " + client);
8290
return fixup(client, clients, evcKey, timeToLive, policy);
8391
}
8492
}
@@ -89,6 +97,7 @@ public EVCacheLatch add(EVCacheKey evcKey, final CachedData cd, Transcoder evcac
8997
}
9098

9199
private EVCacheLatch fixup(EVCacheClient sourceClient, EVCacheClient[] destClients, EVCacheKey evcKey, int timeToLive, Policy policy) {
100+
if (log.isDebugEnabled()) log.debug("Trying to fix up!! destClient count = " + destClients.length);
92101
final EVCacheLatchImpl latch = new EVCacheLatchImpl(policy, destClients.length, _appName);
93102
try {
94103
final CachedData readData = sourceClient.get(evcKey.getDerivedKey(sourceClient.isDuetClient(), sourceClient.getHashingAlgorithm(), sourceClient.shouldEncodeHashKey(), sourceClient.getMaxDigestBytes(), sourceClient.getMaxHashLength(), sourceClient.getBaseEncoder()), ct, false, false);

0 commit comments

Comments
 (0)