Fix generating Kotlin closure projections for generateClientv2 #913
+73
−75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiholee17
requested review from
asibross,
iparadiso,
iuliiasobolevska,
jjacobs44,
kilink,
kzwang,
paulbakker and
srinivasankavitha
as code owners
jiholee17
force-pushed
the
fix/kotlin-closures-v2
branch
from
ce5e156 to
915a975
Compare
jjacobs44
approved these changes
Jan 13, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #896
generateClientandgenerateClientv2should behave the same. Currently, settinggenerateKotlinClosureProjections = truein combination withgenerateClientv2 = truedoes not properly generate Kotlin2 client types because we only check for thegenerateClientflag.This PR merges
generateClientandgenerateClientv2Gradle flags into a single value in codegen that is used to determine whether or not to generate a client.