feat(case_priority): adds ability to disable after-hours warning for case priorities #6127
+65
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Adds a new disable_delayed_message_warning flag to case priorities so that after-hours Slack notifications can be disabled per priority.
- Introduces a nullable boolean column and model field for the new flag
- Updates the UI form, project initialization, and Slack flow to respect the flag
- Includes an Alembic migration to add the column to the database
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/dispatch/static/dispatch/src/case/priority/store.js | Initialized disable_delayed_message_warning in default selected state |
| src/dispatch/static/dispatch/src/case/priority/NewEditSheet.vue | Added checkbox input and mapped state for the new flag |
| src/dispatch/project/flows.py | Populates the new flag from project configuration |
| src/dispatch/plugins/dispatch_slack/case/interactive.py | Skips sending after-hours warning when flag is set |
| src/dispatch/database/revisions/tenant/versions/2025-07-12_6e66b6578810.py | Adds migration to create the new boolean column |
| src/dispatch/case/priority/models.py | Defines the new column and Pydantic field |
| src/dispatch/case/priority/config.py | Sets default values for the new flag in priority presets |
Comments suppressed due to low confidence (2)
src/dispatch/plugins/dispatch_slack/case/interactive.py:1333
- Add a unit or integration test to verify that when
disable_delayed_message_warningisTrue, the after-hours notification is indeed skipped.
if case_priority_data.disable_delayed_message_warning:
src/dispatch/case/priority/models.py:52
- Update your API documentation (e.g., OpenAPI schema or user guide) to include
disable_delayed_message_warningso consumers know about the new field.
disable_delayed_message_warning: bool | None = None
src/dispatch/database/revisions/tenant/versions/2025-07-12_6e66b6578810.py
Outdated
Show resolved
Hide resolved
wssheldon
approved these changes
Jul 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new
disable_delayed_message_warningflag to case priorities so that after-hours Slack notifications can be disabled per priority.