refactor: remove dependency on apache http client #1582
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing dependency on apache http client verion 4 from
eureka-client
. Below is copied from #1581 :As I see
org.apache.httpcomponents:httpclient:4.5.3
is needed only for 3 classes -MonitoredConnectionManager,
NamedConnectionPool
andSSLSocketFactoryAdapter
, which are not used anywhere else in the code. Also from what I see in implementation and current state of spring cloud netflix - it looks likeeureka-client
is now uses everywhere EurekaHttpClient interface and doesn't not need to provide http client implementation itself.eureka-client
except java doc inEurekaClientConfig
eureka-client-jersey3
inEurekaJersey3ClientImpl
, but implementation are provided by transitive dependency onorg.glassfish.jersey.connectors:jersey-apache-connector:3.0.5
eureka-core
tests inTestableHttpReplicationClient
, but implementation are provided by transitive dependency oneureka-test-utils
, which depends oneureka-core-jersey3
, which depends onorg.glassfish.jersey.connectors:jersey-apache-connector:3.0.5