WIP: Add the ability to package more libraries #2269
Conversation
romain-intel
force-pushed
the
feat/extended_packaging
branch
from
15e6e31 to
7b4c66f
Compare
romain-intel
force-pushed
the
feat/extended_packaging
branch
from
7b4c66f to
789e841
Compare
romain-intel
force-pushed
the
feat/extended_packaging
branch
from
b27ab32 to
f665237
Compare
romain-intel
force-pushed
the
feat/extended_packaging
branch
from
f665237 to
c8a8af3
Compare
savingoyal
force-pushed
the
feat/extended_packaging
branch
from
e33972c to
8a3aabc
Compare
metaflow/meta_files.py
Outdated
There was a problem hiding this comment.
the uv_environment now depends on read_info_file so the import needs to be updated. Be sure to rebase this at some point to catch such errors.
| os.path.join(self.metaflow_dir.name, os.path.basename(INFO_FILE)), | ||
| os.path.join( | ||
| self.metaflow_dir.name, | ||
| os.path.basename(MetaFile.INFO_FILE.value), |
There was a problem hiding this comment.
MetaFile.INFO_FILE.value is just a filename so os.path.basename here seems unnecessary
| @@ -162,6 +161,8 @@ def get_username(): | |||
|
|
|||
|
|
|||
| def resolve_identity_as_tuple(): | |||
| from metaflow.exception import MetaflowUnknownUser | |||
There was a problem hiding this comment.
was moving these imports necessary? no objections, just wondering.
(Conda still needs to be fixed to use correct file)
Separating out the Tar backend portion so it can be replaced by something else. Internally, at Netflix, we also have the need for a zip packaging and separating it out like this make it possible. The code in MetaflowPackaging is also much cleaner and clearer focusing simply on *what* to package and not specifically on the how (moving out all the walking code, the actual taring, etc).
madhur-ob
force-pushed
the
feat/extended_packaging
branch
from
8a3aabc to
51323cf
Compare
| if _py_ver >= (3, 8): | ||
| from importlib import metadata | ||
| elif _py_ver >= (3, 7): | ||
| from metaflow._vendor.v3_7 import importlib_metadata as metadata |
There was a problem hiding this comment.
earlier, it was from metaflow._vendor import importlib_metadata as metadata
but we do have a separate folder for v3_7
thus, I changed the import to:
from metaflow._vendor.v3_7 import importlib_metadata as metadata
| if _py_ver >= (3, 8): | ||
| from importlib import metadata | ||
| elif _py_ver >= (3, 7): | ||
| from metaflow._vendor.v3_7 import importlib_metadata as metadata |
There was a problem hiding this comment.
same comment as before:
earlier, it was from metaflow._vendor import importlib_metadata as metadata
but we do have a separate folder for v3_7
thus, I changed the import to:
from metaflow._vendor.v3_7 import importlib_metadata as metadata
No description provided.