Add Custom Elements Everywhere test suite. #111
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the future, we may choose to add this test suite to the custom-elements-everywhere repo. However, we should make sure that our current test suite covers this need so that we don’t somehow drift as we make changes. Closes #106
Collaborator
Author
|
@klebba — Is this more-or-less what you were thinking as a first step here? |
Contributor
|
Wow, neato — yes I think this looks like the best approach here — I would guess that we score 100% right? |
Collaborator
Author
Yah, for sure. |
Collaborator
Author
|
Moved to #118. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the future, we may choose to add this test suite to the
custom-elements-everywhere repo. However, we should make sure that our
current test suite covers this need so that we don’t somehow drift as
we make changes.
Closes #106
Here's a visual on the test suite for reference (grabbed from the custom elements everywhere page).