Adds arrays to performance test templates. #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theengineear
commented
Mar 6, 2025
| // eslint-disable-next-line no-eval | ||
| return eval(`html\`<div data-id="p1" attr="\${attr}"> | ||
| <div data-id="p2" data-foo one="\${one}" two="\${two}" three="\${three}" four="\${four}" five="\${five}" .six="\${six}" .seven="\${seven}" .eight="\${eight}" .nine="\${nine}" .ten="\${ten}"> | ||
| <div data-id="p3" data-bar="bar"> | ||
| <div data-id="\${id}" boolean ?hidden="\${hidden}" .title="\${title}"> | ||
| \${content1} -- \${content2} | ||
| </div> | ||
| <ul data-id="list"> | ||
| \${(items ?? []).map(item => { |
There was a problem hiding this comment.
Easy peasy to test / compare performance of this stuff — we might as well.
theengineear
commented
Mar 6, 2025
| @@ -1544,12 +1544,16 @@ describe('errors coverage', () => { | |||
| assertThrows(callback, expectedMessage, { startsWith: true }); | |||
| }); | |||
|
|
|||
| ////////////////////////////////////////////////////////////////////////////// | |||
There was a problem hiding this comment.
Missed adding these error-code-block delimiters to the parser tests before. Sneaking them in.
Only demo / test changes here — it’s not too hard to support this since most (all?) templating engines will accept a native _array_ as input for a set of children.
theengineear
force-pushed
the
add-arrays-to-performance-test
branch
from
310423d to
fe9585f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only demo / test changes here — it’s not too hard to support this since most (all?) templating engines will accept a native array as input for a set of children.