Pass standard “Array.map” arguments to “repeat”. #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The “repeat” directive is just a shim to create arrays of _entries_. We may remove this from the interface in the future, but we do need it to function as expected in the interim! Most callers rely on just the first “value” argument, but there’s no good reason not to expose the `(value, index, array)`-triple that a standard callback would receive from “Array.map”.
theengineear
commented
Mar 9, 2025
| @@ -1241,6 +1241,38 @@ describe('html updaters', () => { | |||
| assert(container.querySelector('#c').textContent === 'fuzz'); | |||
| container.remove(); | |||
| }); | |||
|
|
|||
| it('repeat callbacks are provided args from underlying “.map” call', () => { | |||
There was a problem hiding this comment.
FYI —Added this test first to prove that we could repro failure in our test suite. Then, added the related fix.
theengineear
commented
Mar 9, 2025
| @@ -126,8 +126,8 @@ class TemplateEngine { | |||
| throw new Error(`Unexpected repeat callback "${callback}" provided, expected a function.`); | |||
| } | |||
| return identify | |||
| ? items.map(item => [identify(item), callback(item)]) | |||
| : items.map(item => callback(item)); // Just a basic array. | |||
| ? items.map((...args) => [identify(...args), callback(...args)]) | |||
There was a problem hiding this comment.
Super simple fix to just pass everything through as-is.
|
FYI @klebba — noticed this one while I was working today. It was a quick fix, so I figured I’d throw in a quick update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The “repeat” directive is just a shim to create arrays of entries. We may remove this from the interface in the future, but we do need it to function as expected in the interim!
Most callers rely on just the first “value” argument, but there’s no good reason not to expose the
(value, index, array)-triple that a standard callback would receive from “Array.map”.