Finalize segments + layout flags (plain, small, starknet_with_keccak) #432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…moved to the layout
* Create layout flag with layouts plain and small * Fix error handling * Fix error handling * Add layout flag to Nethermind vm in the integration tests * Fix unit tests * Fix builtins integration tests, add layouts to builtins tests, remove failing "slices" package
MaksymMalicki
changed the title
har777
reviewed
Jun 3, 2024
MaksymMalicki
changed the title
TAdev0
reviewed
Jun 17, 2024
There was a problem hiding this comment.
@MaksymMalicki just finished the review, left a bunch of comments!
TAdev0
reviewed
Jun 17, 2024
TAdev0
reviewed
Jun 17, 2024
TAdev0
approved these changes
Jun 18, 2024
cicr99
reviewed
Jun 19, 2024
cicr99
approved these changes
Jun 21, 2024
|
I'm resolving the conversations regarding adding comments to the code. Those can be added in a separate PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.