Refactor 2nd stage #77
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omibo
force-pushed
the
refactor_2nd_stage
branch
from
282d82e to
0f9265c
Compare
UpdateRecent commits resolve the following issues:
|
1. Add documentation for subodules and functions of this module 2. Add debug_assert! for some checks in compile time. 3. Change some function names for better readability
…es the sqrt() and then again ^2 operations, and improve efficiency.`
…committing to. Also, changed the norm bound of matrix_d in common_instances to cover the fact that in our implementation, values of h_ij garbage polynomial are twice the original implementation.
zq, rq, and rq_vector modules include: 1. mod tests for testing arithmatization and operation. 2. mod norm_tests for testing l2 and linf norms. 3. decomposition_tests for testing decomposition.
This was referenced Jun 24, 2025
sonnetx
reviewed
Jul 17, 2025
sonnetx
reviewed
Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR completes the refactoring stage to enhance code efficiency and readability. The following changes have been made:
Normtrait in theringmodule to remove repetetive norm computation functionalities.verifier()function into smaller functions.Next Steps
calculate_gh_ci_cj()andcalculate_phi_z_c()functions.usizedata types withu32oru64.check_final_norm_sum(), which incorrectly compares the norm bound against beta instead of beta'. Currently, using beta' failstest_verifytest case.