Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Cairo0 Class Hash #2111

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Implement Cairo0 Class Hash #2111

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
a3b8405
Implement Cairo0 Class Hash
weiihann Aug 29, 2024
7a8b6b9
Clean up code
weiihann Sep 10, 2024
0c524e0
Remove core/rust deps
weiihann Sep 10, 2024
8f42417
Fix linting
weiihann Sep 13, 2024
8d67905
Add more comments
weiihann Sep 13, 2024
5e46bae
Fix linting
weiihann Sep 13, 2024
f74ec1d
Fix potentially unsafe quoting
weiihann Sep 13, 2024
6836ec3
Remove /core/rust from CI
weiihann Sep 26, 2024
d801a3b
Minor fixes
weiihann Sep 27, 2024
1cb8ed8
Change interface{} to any for better readability
weiihann Sep 27, 2024
e493ea1
Use digest instead of array
weiihann Sep 27, 2024
3b82452
Tidy up code
weiihann Oct 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/find-smallest-rust.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ on:
- main
paths:
- .github/workflows/find-smallest-rust.yml
- core/rust/*
- vm/rust/*
- starknet/compiler/rust/*
workflow_dispatch:
Expand All @@ -24,7 +23,7 @@ jobs:
id: rust-version
uses: derrix060/detect-rust-minimum-version@v1
with:
paths: core/rust/,vm/rust/,starknet/compiler/rust/
paths: vm/rust/,starknet/compiler/rust/
- name: Send notification on PR
uses: actions/github-script@v7
with:
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/juno-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ jobs:
with:
workspaces: |
vm/rust
core/rust
starknet/compiler/rust

- name: Install deps
Expand Down
7 changes: 1 addition & 6 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ endif

MAKEFLAGS += -j$(NPROCS)

rustdeps: vm core-rust compiler
rustdeps: vm compiler

juno: rustdeps ## compile
@mkdir -p build
Expand All @@ -44,9 +44,6 @@ juno-cached:
vm:
$(MAKE) -C vm/rust $(VM_TARGET)

core-rust:
$(MAKE) -C core/rust $(VM_TARGET)

compiler:
$(MAKE) -C starknet/compiler/rust $(VM_TARGET)

Expand Down Expand Up @@ -93,13 +90,11 @@ tidy: ## add missing and remove unused modules

format: ## run go & rust formatters
$(MAKE) -C vm/rust format
$(MAKE) -C core/rust format
$(MAKE) -C starknet/compiler/rust format
gofumpt -l -w .

clean: ## clean project builds
$(MAKE) -C vm/rust clean
$(MAKE) -C core/rust clean
$(MAKE) -C starknet/compiler/rust clean
@rm -rf ./build

Expand Down
4 changes: 2 additions & 2 deletions clients/feeder/feeder.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ func NopBackoff(d time.Duration) time.Duration {
}

// NewTestClient returns a client and a function to close a test server.
func NewTestClient(t *testing.T, network *utils.Network) *Client {
func NewTestClient(t testing.TB, network *utils.Network) *Client {
srv := newTestServer(t, network)
t.Cleanup(srv.Close)
ua := "Juno/v0.0.1-test Starknet Implementation"
Expand All @@ -117,7 +117,7 @@ func NewTestClient(t *testing.T, network *utils.Network) *Client {
return c
}

func newTestServer(t *testing.T, network *utils.Network) *httptest.Server {
func newTestServer(t testing.TB, network *utils.Network) *httptest.Server {
return httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
queryMap, err := url.ParseQuery(r.URL.RawQuery)
if err != nil {
Expand Down
Loading