Fix #2175 - Add SignatureCarrier interface for transactions with signatures #2189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…i-3x/juno into priyanshu/signature-interface
derrix060
reviewed
Oct 4, 2024
| @@ -57,7 +57,7 @@ func TestTransactionCommitmentPoseidon(t *testing.T) { | |||
|
|
|||
| c, err := transactionCommitmentPoseidon(txs) | |||
| require.NoError(t, err) | |||
| expected := utils.HexToFelt(t, "0x6e067f82eefc8efa75b4ad389253757f4992eee0f81f0b43815fa56135ca801") | |||
| expected := utils.HexToFelt(t, "0x5ecb75d7a86984ec8ef9d5fbbe49ef8737c37246d33cf73037df1ceb412244e") | |||
There was a problem hiding this comment.
Can you explain why the hash changed?
There was a problem hiding this comment.
@derrix060 The hash changed due to the introduction of the SignatureCarrier interface, which altered how signatures are handled in the hash calculation. I got this hash, when I ran the test case.
Test: TestTransactionCommitmentPoseidon/txs_without_signature
Messages: expected: 0x6e067f82eefc8efa75b4ad389253757f4992eee0f81f0b43815fa56135ca801,
got: 0x5ecb75d7a86984ec8ef9d5fbbe49ef8737c37246d33cf73037df1ceb412244e
|
This pull request is stale because it has been open 35 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to issue #2175
-Add
SignatureCarrierinterface for improved transaction signature handling.