-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure p2p protocol matches new Starknet spec #2291
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2291 +/- ##
=======================================
Coverage 74.41% 74.41%
=======================================
Files 109 109
Lines 11493 11493
=======================================
Hits 8552 8552
Misses 2277 2277
Partials 664 664 ☔ View full report in Codecov by Sentry. |
ee1b5ee
to
ff56ae3
Compare
ff56ae3
to
586824e
Compare
586824e
to
ff3cdc2
Compare
426e56d
to
df1ed30
Compare
4c6a03d
to
b5190ac
Compare
b5190ac
to
a2264f6
Compare
a2264f6
to
fee852d
Compare
AnkushinDaniil
approved these changes
Dec 16, 2024
kirugan
reviewed
Dec 16, 2024
d0f341c
to
f5bdcb6
Compare
f5bdcb6
to
3377721
Compare
The change ensures that DHT protocol follow latest Starknet specification.
3377721
to
54ff331
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/starknet/<chain_id>/sync/...
Protocol Path Changes:
Before:
/starknet/headers/0.1.0-rc.0
/starknet/events/0.1.0-rc.0
After:
/starknet/SN_MAIN/sync/headers/0.1.0-rc.0
/starknet/SN_SEPOLIA/sync/events/0.1.0-rc.0