Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dont log error for not_received responses from the fgw #2304

Merged

Conversation

rianhughes
Copy link
Contributor

@rianhughes rianhughes commented Dec 5, 2024

Just a suggestion for this PR

@rianhughes rianhughes requested a review from wojciechos December 5, 2024 09:08
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.36%. Comparing base (09c60ba) to head (0840cf3).
Report is 1 commits behind head on wojciechos/handle_not_received.

Additional details and impacted files
@@                        Coverage Diff                         @@
##           wojciechos/handle_not_received    #2304      +/-   ##
==================================================================
- Coverage                           75.39%   75.36%   -0.04%     
==================================================================
  Files                                 107      107              
  Lines                               11411    11409       -2     
==================================================================
- Hits                                 8603     8598       -5     
- Misses                               2154     2156       +2     
- Partials                              654      655       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wojciechos wojciechos merged commit c248fd2 into wojciechos/handle_not_received Dec 5, 2024
5 checks passed
@wojciechos wojciechos deleted the rianhughes/adaptTxnStatusErr branch December 5, 2024 09:16
wojciechos pushed a commit that referenced this pull request Dec 5, 2024
* dont log error for not_received responses from the fgw

* lint
wojciechos pushed a commit that referenced this pull request Dec 9, 2024
* dont log error for not_received responses from the fgw

* lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants