Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes a small but important change to the Run method in the rpc/handlers.go file. The change ensures thread safety by locking and unlocking a mutex around the loop that waits for all subscriptions to complete.
Reason for the Change:
During testing, I encountered a panic that occurred intermittently—sometimes the tests would pass, and other times they would fail unpredictably. This behavior was caused by concurrent access to the map of active subscriptions during iteration, resulting in a race condition. Such issues are common in Go when shared resources are accessed by multiple goroutines without proper synchronization.
Solution:
To address this, I added a mutex lock around the loop that processes subscriptions.