Skip to content

Conversation

@rianhughes
Copy link
Contributor

@rianhughes rianhughes commented Jan 13, 2025

This PR implements the genesis pkg that builds a state diff from declaring classes, deploying contracts and invoking functions. The sequencer can then commit this state diff to state, so that upon startup, a set of account contracts have already been deployed and funded (it is not possible to achieve this from an empty state by submitting transactions, since Starknet requires accounts to be funded to perform any actions on the state - originally this wasn't a requirement in Starknet). This is particularly useful as it allows users to start the sequencer with any number of accounts pre-deployed, and pre-funded, etc, and opens up the possibility of using Juno as a devnet

In essence:

  1. we load classes, then declare them,
  2. execute the constructor functions using the vm, which writes the changes to the pending state
  3. execute any functions of interest (eg token transfers) using the vm (where similarly the vm writes the changes to the pending state)
  4. extract the state-diff and new classes from the pending state.

@rianhughes rianhughes marked this pull request as draft January 13, 2025 12:29
@rianhughes rianhughes force-pushed the feature/sequencer-genesis branch from fb11e07 to 459db5d Compare January 13, 2025 14:37
@rianhughes rianhughes marked this pull request as ready for review January 13, 2025 14:38
@codecov
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 66.37427% with 115 lines in your changes missing coverage. Please review.

Project coverage is 75.11%. Comparing base (adf229e) to head (fd7fc4f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
genesis/genesis.go 63.39% 56 Missing and 26 partials ⚠️
sync/pending.go 60.37% 19 Missing and 2 partials ⚠️
adapters/vm2core/vm2core.go 71.05% 8 Missing and 3 partials ⚠️
node/throttled_vm.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2371      +/-   ##
==========================================
- Coverage   75.29%   75.11%   -0.18%     
==========================================
  Files         140      141       +1     
  Lines       16848    17186     +338     
==========================================
+ Hits        12686    12910     +224     
- Misses       3336     3416      +80     
- Partials      826      860      +34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@AnkushinDaniil AnkushinDaniil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have finished reviewing everything except vm logic. Everything is good, just small changes and questions. I'll continue reviewing vm logic.

@cicr99
Copy link
Contributor

cicr99 commented Jan 24, 2025

Even though the PR is approved, I'm adding the blocked label up until all the changes regarding the new blockifier release are finished. This takes priority and will probably cause conflicts with the changes done to the vm pkg in this PR.

@rianhughes
Copy link
Contributor Author

Relevant blockifier PR #2397

Copy link
Collaborator

@rodrodros rodrodros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just putting a blocking comment here to make sure it doesn't get merged by accident during this release process.

I would also like to give a final review before moving ahead with the PR.

@rianhughes
Copy link
Contributor Author

Failing test fixed by #2645

@rianhughes rianhughes merged commit c3953c0 into main Mar 17, 2025
18 of 19 checks passed
@rianhughes rianhughes deleted the feature/sequencer-genesis branch March 17, 2025 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants