Set correct DHT protocol to match Starknet P2P v0.1 #2380
Closed
+44
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wojciechos
force-pushed
the
wojciechos/adjust-p2p-naming
branch
2 times, most recently
from
7a7d296 to
fc245de
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2380 +/- ##
=======================================
Coverage 74.41% 74.42%
=======================================
Files 113 113
Lines 13016 13016
=======================================
+ Hits 9686 9687 +1
- Misses 2592 2594 +2
+ Partials 738 735 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
wojciechos
force-pushed
the
wojciechos/adjust-p2p-naming
branch
3 times, most recently
from
b0b5de8 to
8dec96e
Compare
wojciechos
force-pushed
the
wojciechos/adjust-p2p-naming
branch
from
8dec96e to
8ce0d16
Compare
@AnkushinDaniil Yep, I tested, but Pathfinder hasn’t updated to the latest P2P spec, which is why it can’t sync with each other. See here |
AnkushinDaniil
approved these changes
Jan 27, 2025
wojciechos
force-pushed
the
wojciechos/adjust-p2p-naming
branch
from
1da486c to
0e85e86
Compare
wojciechos
changed the title
wojciechos
force-pushed
the
wojciechos/adjust-p2p-naming
branch
from
0e85e86 to
f705e54
Compare
AnkushinDaniil
approved these changes
Jan 31, 2025
derrix060
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated DHT protocol naming to align with Starknet P2P v0.1 spec and added a test.
Changes:
• Fixed incorrect DHT protocol naming:
• Before: /starknet/kad/1.0.0 (not matching any Starknet P2P spec)
• After: /starknet/kad/SN_MAIN/1.0.0 (matches v0.1)
• Added a test to validate the correct protocol format.