Skip to content

Refactor: Reuse v6 BlockTransactionCount handler for v7 and v8 #2488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 15, 2025

Conversation

hudem1
Copy link
Contributor

@hudem1 hudem1 commented Feb 14, 2025

rpc pkg cleanup according to #2437

Reuse v6 BlockTransactionCount handler both for v7 and v8 starknet_getBlockTransactionCount endpoint

@hudem1 hudem1 mentioned this pull request Feb 14, 2025
23 tasks
Copy link

codecov bot commented Feb 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.50%. Comparing base (bd16b82) to head (1b95b86).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2488      +/-   ##
==========================================
- Coverage   73.53%   73.50%   -0.04%     
==========================================
  Files         140      140              
  Lines       17147    17130      -17     
==========================================
- Hits        12609    12591      -18     
  Misses       3654     3654              
- Partials      884      885       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rodrigo-pino rodrigo-pino merged commit 66f700c into main Feb 15, 2025
14 checks passed
@rodrigo-pino rodrigo-pino deleted the hudem1/rpc-cleanup-getTransactionCount branch February 15, 2025 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants