Skip to content

Refactor: starknet_estimateMessageFee#2496

Merged
hudem1 merged 2 commits intomainfrom
hudem1/rpc-cleanup-estimateMessageFee
Mar 18, 2025
Merged

Refactor: starknet_estimateMessageFee#2496
hudem1 merged 2 commits intomainfrom
hudem1/rpc-cleanup-estimateMessageFee

Conversation

@hudem1
Copy link
Contributor

@hudem1 hudem1 commented Feb 16, 2025

rpc pkg cleanup according to #2437

Reuse v6 SimulationFlag and MsgFromL1 types for v7 and v8

As i was looking into refactoring starknet_estimateMessageFee endpoint, i just found those 2 types to refactor. I don't know if we really want to refactor those, but i opened a PR in case. Let me know if we don't necessarily want to refactor those

@hudem1 hudem1 changed the title Refactor: Reuse v6 SimulationFlag and MsgFromL1 types for v7 and v8 Refactor: starknet_estimateMessageFee Feb 16, 2025
@hudem1 hudem1 mentioned this pull request Feb 16, 2025
23 tasks
@codecov
Copy link

codecov bot commented Feb 16, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 73.73%. Comparing base (94071e4) to head (07e8456).
Report is 54 commits behind head on main.

Files with missing lines Patch % Lines
rpc/v8/estimate_fee.go 33.33% 2 Missing ⚠️
rpc/v7/estimate_fee.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2496      +/-   ##
==========================================
+ Coverage   73.65%   73.73%   +0.07%     
==========================================
  Files         137      137              
  Lines       16659    16641      -18     
==========================================
  Hits        12271    12271              
+ Misses       3526     3511      -15     
+ Partials      862      859       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hudem1 hudem1 added RPC JSON RPC API Refactor labels Feb 17, 2025
@rianhughes rianhughes self-requested a review February 24, 2025 15:15
@rianhughes
Copy link
Contributor

LGTM, just need to address the starknet_estFee flags bug

@hudem1 hudem1 merged commit eab8f0e into main Mar 18, 2025
14 checks passed
@hudem1 hudem1 deleted the hudem1/rpc-cleanup-estimateMessageFee branch March 18, 2025 09:11
wojciechos pushed a commit that referenced this pull request Mar 21, 2025
Refactor: Reuse v6 SimulationFlag and MsgFromL1 for v7 and v8
wojciechos pushed a commit that referenced this pull request Mar 21, 2025
Refactor: Reuse v6 SimulationFlag and MsgFromL1 for v7 and v8
wojciechos pushed a commit that referenced this pull request Mar 22, 2025
Refactor: Reuse v6 SimulationFlag and MsgFromL1 for v7 and v8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Refactor RPC JSON RPC API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants