Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2496 +/- ##
==========================================
+ Coverage 73.65% 73.73% +0.07%
==========================================
Files 137 137
Lines 16659 16641 -18
==========================================
Hits 12271 12271
+ Misses 3526 3511 -15
+ Partials 862 859 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
AnkushinDaniil
approved these changes
Feb 16, 2025
rianhughes
reviewed
Mar 14, 2025
rianhughes
reviewed
Mar 14, 2025
Contributor
|
LGTM, just need to address the starknet_estFee flags bug |
rianhughes
approved these changes
Mar 17, 2025
wojciechos
pushed a commit
that referenced
this pull request
Mar 21, 2025
Refactor: Reuse v6 SimulationFlag and MsgFromL1 for v7 and v8
wojciechos
pushed a commit
that referenced
this pull request
Mar 21, 2025
Refactor: Reuse v6 SimulationFlag and MsgFromL1 for v7 and v8
wojciechos
pushed a commit
that referenced
this pull request
Mar 22, 2025
Refactor: Reuse v6 SimulationFlag and MsgFromL1 for v7 and v8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rpc pkg cleanup according to #2437
Reuse v6
SimulationFlagandMsgFromL1types for v7 and v8As i was looking into refactoring
starknet_estimateMessageFeeendpoint, i just found those 2 types to refactor. I don't know if we really want to refactor those, but i opened a PR in case. Let me know if we don't necessarily want to refactor those