Refactor: starknet_estimateMessageFee #2496
Conversation
hudem1
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2496 +/- ##
==========================================
+ Coverage 73.65% 73.73% +0.07%
==========================================
Files 137 137
Lines 16659 16641 -18
==========================================
Hits 12271 12271
+ Misses 3526 3511 -15
+ Partials 862 859 -3 ☔ View full report in Codecov by Sentry. |
| @@ -65,9 +66,9 @@ func (f FeeEstimate) MarshalJSON() ([]byte, error) { | |||
| *****************************************************/ | |||
|
|
|||
| func (h *Handler) EstimateFee(broadcastedTxns []BroadcastedTransaction, | |||
| simulationFlags []SimulationFlag, id BlockID, | |||
| simulationFlags []rpcv6.SimulationFlag, id BlockID, | |||
There was a problem hiding this comment.
Hmm, it looks like this is a bug actually. We allow SKIP_FEE_CHARGE which isn't allowed by the spec.
The spec distinguishes between SIMULATION_FLAG_FOR_ESTIMATE_FEE (starknet_estFee) and SIMULATION_FLAG (starknet_sumTxns). This seems to be the case for all rpc versions. Not a critical bug, but should probably be fixed
| @@ -45,9 +46,9 @@ type FeeEstimate struct { | |||
| *****************************************************/ | |||
|
|
|||
| func (h *Handler) EstimateFee(broadcastedTxns []BroadcastedTransaction, | |||
| simulationFlags []SimulationFlag, id BlockID, | |||
| simulationFlags []rpcv6.SimulationFlag, id BlockID, | |||
There was a problem hiding this comment.
Similar bug here (we accept SKIP_FEE_CHARGE, which isn't allowed by the spec)
|
LGTM, just need to address the starknet_estFee flags bug |
rpc pkg cleanup according to #2437
Reuse v6
SimulationFlagandMsgFromL1types for v7 and v8As i was looking into refactoring
starknet_estimateMessageFeeendpoint, i just found those 2 types to refactor. I don't know if we really want to refactor those, but i opened a PR in case. Let me know if we don't necessarily want to refactor those