Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor state and trie integration #2535

Open
wants to merge 68 commits into
base: weiihann/improve-state-trie
Choose a base branch
from

Conversation

weiihann
Copy link
Contributor

@weiihann weiihann commented Feb 24, 2025

TODO: write a more concise PR message...

Please review this PR first.

@weiihann weiihann added the State All things related to state label Feb 24, 2025
Copy link

codecov bot commented Feb 24, 2025

Codecov Report

Attention: Patch coverage is 70.05095% with 823 lines in your changes missing coverage. Please review.

Project coverage is 70.79%. Comparing base (f9b4aed) to head (2701f26).

Files with missing lines Patch % Lines
core/state/state.go 63.22% 105 Missing and 48 partials ⚠️
core/trie2/proof.go 68.02% 103 Missing and 38 partials ⚠️
core/trie2/trieutils/bitarray.go 74.48% 131 Missing and 4 partials ⚠️
core/trie2/trie.go 79.10% 61 Missing and 18 partials ⚠️
core/state/history.go 10.00% 53 Missing and 1 partial ⚠️
core/state/contract.go 71.89% 35 Missing and 17 partials ⚠️
core/trie2/node_enc.go 58.55% 31 Missing and 15 partials ⚠️
core/trie2/triedb/pathdb/database.go 63.91% 26 Missing and 9 partials ⚠️
core/trie2/node.go 44.23% 29 Missing ⚠️
blockchain/state.go 59.61% 14 Missing and 7 partials ⚠️
... and 14 more
Additional details and impacted files
@@                       Coverage Diff                       @@
##           weiihann/improve-state-trie    #2535      +/-   ##
===============================================================
- Coverage                        73.61%   70.79%   -2.82%     
===============================================================
  Files                              136      150      +14     
  Lines                            16658    18193    +1535     
===============================================================
+ Hits                             12262    12879     +617     
- Misses                            3535     4452     +917     
- Partials                           861      862       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@weiihann weiihann force-pushed the weiihann/refactor-state-v2 branch from 9a871f4 to 287f2d8 Compare February 25, 2025 06:08
@weiihann weiihann force-pushed the weiihann/refactor-state-v2 branch from 287f2d8 to eee78bb Compare February 28, 2025 12:30
@weiihann weiihann force-pushed the weiihann/refactor-state-v2 branch from eee78bb to 538f3e1 Compare March 3, 2025 04:35
@weiihann weiihann force-pushed the weiihann/refactor-state-v2 branch from 538f3e1 to f759ace Compare March 3, 2025 06:44
@weiihann weiihann force-pushed the weiihann/refactor-state-v2 branch from f759ace to 2701f26 Compare March 3, 2025 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 reviews Requires at least 3 reviews Refactor State All things related to state
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants