test(node): fix TestNetworkVerificationOnNonEmptyDB #2562
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2495
It seems the issue arises because the timeout is set to 250 milliseconds, which makes the test somewhat racy. This test checks whether the stored blocks are compatible with the provided flag. If no block is received within 250 milliseconds, no error occurs because the state remains empty.
The proposed fix in PR #2494 appears hacky, as it simply increases the window time. I believe increasing the context timeout would be a more appropriate solution in this case.
That said, I wasn't able to reproduce the described error unless I explicitly introduced a delay using time.Sleep() here.