Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vm): exceeding gas limit case should pass #2638

Open
wants to merge 41 commits into
base: main
Choose a base branch
from

Conversation

AnkushinDaniil
Copy link
Contributor

Important

Review after #2634

The code was doing a check that didn't pass the test if the L2 gas limit was above the max gas limit in the transaction resource limits.

@AnkushinDaniil AnkushinDaniil force-pushed the daniil/fix-gas-limit-exceeded-case branch from 7fb1ea8 to 74b9d70 Compare March 13, 2025 06:45
@AnkushinDaniil AnkushinDaniil added Bug Something isn't working or security issue rust Pull requests that update Rust code labels Mar 13, 2025
Copy link

codecov bot commented Mar 13, 2025

Codecov Report

Attention: Patch coverage is 94.27313% with 13 lines in your changes missing coverage. Please review.

Project coverage is 75.54%. Comparing base (93b96c7) to head (6c8f537).

Files with missing lines Patch % Lines
core/test_state.go 55.00% 6 Missing and 3 partials ⚠️
core/state.go 63.63% 0 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2638      +/-   ##
==========================================
+ Coverage   75.14%   75.54%   +0.39%     
==========================================
  Files         140      142       +2     
  Lines       16815    17036     +221     
==========================================
+ Hits        12635    12869     +234     
+ Misses       3347     3329      -18     
- Partials      833      838       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AnkushinDaniil AnkushinDaniil force-pushed the daniil/fix-gas-limit-exceeded-case branch from 74b9d70 to 6c8f537 Compare March 13, 2025 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working or security issue rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant