clean(rpc): refactor & remove unused code #2639
Open
+1,568
−2,238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hudem1
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2639 +/- ##
==========================================
- Coverage 75.20% 75.09% -0.12%
==========================================
Files 140 140
Lines 16815 16786 -29
==========================================
- Hits 12646 12605 -41
- Misses 3340 3349 +9
- Partials 829 832 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rpc/v6/adapters.go
Outdated
| @@ -339,3 +345,392 @@ func adaptFeederExecutionResources(resources *starknet.ExecutionResources) Compu | |||
| SegmentArena: builtins.SegmentArena, | |||
| } | |||
| } | |||
|
|
|||
| func adaptToFeederResourceBounds(rb *map[Resource]ResourceBounds) *map[starknet.Resource]starknet.ResourceBounds { | |||
There was a problem hiding this comment.
No need for pointers, either as input or output parameters. map[K]V is already a pointer by default
There was a problem hiding this comment.
Ah yeah, I just moved those functions from the other file to this file.
Yeah for sure, I'll make the changes to all functions needing it in this PR!
rpc/v6/adapters.go
Outdated
| return &feederResourceBounds | ||
| } | ||
|
|
||
| func adaptToFeederDAMode(mode *DataAvailabilityMode) *starknet.DataAvailabilityMode { |
There was a problem hiding this comment.
Return value type here.
|
This approach looks good to me |
…ue instead of pointers when possible
…ue instead of pointers when possible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a PR to clean / reorganize a bit