chore: remove dead config->map decode and unused mapstructure import#3250
Open
Forostovec wants to merge 2 commits intoNethermindEth:mainfrom
Open
chore: remove dead config->map decode and unused mapstructure import#3250Forostovec wants to merge 2 commits intoNethermindEth:mainfrom
Forostovec wants to merge 2 commits intoNethermindEth:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3250 +/- ##
==========================================
- Coverage 76.68% 76.64% -0.05%
==========================================
Files 322 322
Lines 31841 31842 +1
==========================================
- Hits 24417 24404 -13
+ Misses 5685 5682 -3
- Partials 1739 1756 +17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
This pull request is stale because it has been open 35 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change removes an unnecessary config-to-map mapstructure.Decode in node.Node.Run and the corresponding unused mapstructure import. The decoded map was never used (logging uses yaml.Marshal(n.cfg) directly), which made the block dead code and added avoidable allocations and an extra failure path during startup.