refactor(juno): Use common interfaces in Juno#3283
Open
MaksymMalicki wants to merge 2 commits intomainfrom
Open
refactor(juno): Use common interfaces in Juno#3283MaksymMalicki wants to merge 2 commits intomainfrom
MaksymMalicki wants to merge 2 commits intomainfrom
Conversation
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (52.87%) is below the target coverage (60.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #3283 +/- ##
==========================================
+ Coverage 75.98% 76.08% +0.09%
==========================================
Files 377 377
Lines 34614 34574 -40
==========================================
+ Hits 26301 26304 +3
+ Misses 6466 6426 -40
+ Partials 1847 1844 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced Nov 21, 2025
225d960 to
2168fca
Compare
42162a8 to
3fb0091
Compare
561eca9 to
ac44bab
Compare
ac44bab to
21af273
Compare
rodrodros
approved these changes
Dec 8, 2025
21af273 to
6a4d516
Compare
6a4d516 to
a55633f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR should be reviewed after #3282 . It aims to:
StateandTrieinterfaces fromcommonstateandcommontriepackages tocorepackage and rename them toCommonStateandCommonTrie. This way the circular imports inpending_state.goare omitted and there is no naming clash.CommonStateandCommonTriein Juno. Right now both old and new implementations of State and Trie use these interfaces. It is possible to utilise the new interfaces in Juno, but always feed the old implementations to them. The CMD flag, specifying which set of implementations to use will be introduced in the next PR.CompiledClassHash()andCompiledClassHashV2()methods for the newStateMockStateHistoryReaderand all its methods toMockCommonStateThe next PR to review: #3187