Skip to content

Conversation

@infrmtcs
Copy link
Contributor

No description provided.

@infrmtcs infrmtcs changed the title migration/blocktransactions/batch_provider.goDat/migrate block transactions feat: Implement migration script for combined layout Dec 30, 2025
@infrmtcs infrmtcs added the disable-deploy-test We don't want to run deploy tests with this PR because it might affect our development environment. label Dec 30, 2025
@codecov
Copy link

codecov bot commented Dec 30, 2025

Codecov Report

❌ Patch coverage is 0% with 255 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.72%. Comparing base (b6b926b) to head (7aa89b8).

Files with missing lines Patch % Lines
migration/blocktransactions/ingestor.go 0.00% 91 Missing ⚠️
migration/blocktransactions/blocktransactions.go 0.00% 45 Missing ⚠️
migration/blocktransactions/check_status.go 0.00% 33 Missing ⚠️
migration/blocktransactions/counter.go 0.00% 29 Missing ⚠️
migration/blocktransactions/committer.go 0.00% 26 Missing ⚠️
migration/blocktransactions/batch_provider.go 0.00% 17 Missing ⚠️
migration/blocktransactions/pipeline.go 0.00% 14 Missing ⚠️

❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (60.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3355      +/-   ##
==========================================
- Coverage   76.36%   75.72%   -0.65%     
==========================================
  Files         351      358       +7     
  Lines       33309    33564     +255     
==========================================
- Hits        25438    25416      -22     
- Misses       6062     6333     +271     
- Partials     1809     1815       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@infrmtcs infrmtcs force-pushed the dat/migrate-block-transactions branch from b650e4f to 60b4f1a Compare December 30, 2025 15:26
@infrmtcs infrmtcs force-pushed the dat/block-transactions branch from 492d696 to 172042a Compare December 30, 2025 15:26
@infrmtcs infrmtcs force-pushed the dat/migrate-block-transactions branch from 60b4f1a to 1795554 Compare January 6, 2026 09:29
return 0, false, nil
}

minBlock := min(transactions, receipts)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How we will proceed iftransactions != receipts? Seems like this will failvalidateCountand we can exit early here since transactions != receipts should hint DB corruption.


if !shouldMigrate {
logger.Infow("no starting block found, exiting")
return shouldNotRerun, clearOldBuckets(database)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does clearOldBuckets had positive effect? If so can you add brief comment why we call it while !shouldMigrate is hinting buckets are already empty

@infrmtcs infrmtcs force-pushed the dat/block-transactions branch from 172042a to e88c8e6 Compare January 6, 2026 14:53
Base automatically changed from dat/block-transactions to main January 6, 2026 15:38
@infrmtcs infrmtcs force-pushed the dat/migrate-block-transactions branch 2 times, most recently from 597f206 to a9bb926 Compare January 7, 2026 12:38
@infrmtcs infrmtcs force-pushed the dat/migrate-block-transactions branch from a9bb926 to 7aa89b8 Compare January 7, 2026 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

disable-deploy-test We don't want to run deploy tests with this PR because it might affect our development environment.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants