-
Notifications
You must be signed in to change notification settings - Fork 222
feat: Implement migration script for combined layout #3355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (60.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #3355 +/- ##
==========================================
- Coverage 76.36% 75.72% -0.65%
==========================================
Files 351 358 +7
Lines 33309 33564 +255
==========================================
- Hits 25438 25416 -22
- Misses 6062 6333 +271
- Partials 1809 1815 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
b650e4f to
60b4f1a
Compare
492d696 to
172042a
Compare
60b4f1a to
1795554
Compare
| return 0, false, nil | ||
| } | ||
|
|
||
| minBlock := min(transactions, receipts) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How we will proceed iftransactions != receipts? Seems like this will failvalidateCountand we can exit early here since transactions != receipts should hint DB corruption.
|
|
||
| if !shouldMigrate { | ||
| logger.Infow("no starting block found, exiting") | ||
| return shouldNotRerun, clearOldBuckets(database) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does clearOldBuckets had positive effect? If so can you add brief comment why we call it while !shouldMigrate is hinting buckets are already empty
172042a to
e88c8e6
Compare
597f206 to
a9bb926
Compare
a9bb926 to
7aa89b8
Compare
No description provided.