Skip to content

chore: fix lint errors#3369

Merged
rodrodros merged 10 commits intomainfrom
rdr/lint-fix
Jan 15, 2026
Merged

chore: fix lint errors#3369
rodrodros merged 10 commits intomainfrom
rdr/lint-fix

Conversation

@rodrodros
Copy link
Contributor

Fixing linting errors

@codecov
Copy link

codecov bot commented Jan 9, 2026

Codecov Report

❌ Patch coverage is 70.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.19%. Comparing base (646ef43) to head (bef843d).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
core/trie/bitarray.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3369      +/-   ##
==========================================
- Coverage   76.25%   76.19%   -0.07%     
==========================================
  Files         351      351              
  Lines       33340    33365      +25     
==========================================
- Hits        25423    25422       -1     
- Misses       6103     6131      +28     
+ Partials     1814     1812       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@EgeCaner EgeCaner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can initialize the slices with size and assign by index, but I'm not sure if it worth doing since all those are test code and difference should be negligible.

res = append(res, b.len)
res = append(res, bt[:]...)

// 1 byte to accomoaate the length and the other 32 for the data
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// 1 byte to accomoaate the length and the other 32 for the data
// 1 byte to accommodate the length and the other 32 for the data


// put random 64 keys and record roots
for range 64 {
const amount = 64
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

turbo small nit: I'd rename amount to something like numKeys

@rodrodros
Copy link
Contributor Author

We can initialize the slices with size and assign by index, but I'm not sure if it worth doing since all those are test code and difference should be negligible.

There were some cases where it was not trivial so I decided to leave it as it is (unless trivial) in the test code. I did change all production code that would benefit from this.

@rodrodros rodrodros merged commit b42a11b into main Jan 15, 2026
19 of 22 checks passed
@rodrodros rodrodros deleted the rdr/lint-fix branch January 15, 2026 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants