chore: fix lint errors #3369
chore: fix lint errors #3369
Conversation
Made it apply to only trivial cases, otherwise too much false positives.
fix: p2p utils
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (57.14%) is below the target coverage (60.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #3369 +/- ##
==========================================
+ Coverage 76.25% 76.27% +0.01%
==========================================
Files 351 351
Lines 33340 33340
==========================================
+ Hits 25423 25429 +6
+ Misses 6103 6095 -8
- Partials 1814 1816 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
EgeCaner
left a comment
EgeCaner
left a comment
There was a problem hiding this comment.
We can initialize the slices with size and assign by index, but I'm not sure if it worth doing since all those are test code and difference should be negligible.
| res = append(res, b.len) | ||
| res = append(res, bt[:]...) | ||
|
|
||
| // 1 byte to accomoaate the length and the other 32 for the data |
There was a problem hiding this comment.
| // 1 byte to accomoaate the length and the other 32 for the data | |
| // 1 byte to accommodate the length and the other 32 for the data |
|
|
||
| // put random 64 keys and record roots | ||
| for range 64 { | ||
| const amount = 64 |
There was a problem hiding this comment.
turbo small nit: I'd rename amount to something like numKeys
Fixing linting errors