feat: optimize some methods of the trie package#3370
Open
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3370 +/- ##
==========================================
- Coverage 76.22% 75.82% -0.41%
==========================================
Files 351 351
Lines 33365 33397 +32
==========================================
- Hits 25433 25322 -111
- Misses 6117 6157 +40
- Partials 1815 1918 +103 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rodrodros
force-pushed
the
rdr/trie-improvements
branch
from
20d6b8c to
689ca06
Compare
| // Example: | ||
| // | ||
| // The returned error is always nil | ||
| // Example: Err |
Contributor
There was a problem hiding this comment.
I don't understand this comment, what does Example: Err mean?
| dst = dst[nodeTypeSize:] | ||
|
|
||
| pathBytes := path.Bytes() | ||
| copy(dst, pathBytes[0:pathSize]) |
Contributor
There was a problem hiding this comment.
doesn't path.Bytes() return big-endian? What happens, when the pathSize is not 32?
fix: errors in bitarray utilities fix: trie2
rodrodros
force-pushed
the
rdr/trie-improvements
branch
from
689ca06 to
f988741
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some small optimization to the trie methods