ci: update Rust version detection action and enforce Cargo.lock usage #3373
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| - name: Find smallest supported Rust version | ||
| id: rust-version | ||
| uses: derrix060/detect-rust-minimum-version@v1 | ||
| uses: derrix060/detect-rust-minimum-version@v1.1.0 |
Check warning
Code scanning / CodeQL
Unpinned tag for a non-immutable Action in workflow Medium
There was a problem hiding this comment.
Pull request overview
This PR updates the Rust version detection workflow to use a specific version (v1.1.0) of the detect-rust-minimum-version action and enforces the use of Cargo.lock files to prevent dependency drift. It also sets a minimum Rust version floor of 1.78.0 to align with Cargo.lock v4 requirements.
Changes:
- Updated GitHub Action from
v1tov1.1.0for better version control - Added
locked: "true"parameter to enforce Cargo.lock usage - Added
min: "1.78.0"parameter to set minimum Rust version floor
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| with: | ||
| paths: core/rust/,vm/rust/,starknet/compiler/rust/ | ||
| locked: "true" # Enforce using Cargo.lock to prevent dependency drift | ||
| min: "1.78.0" # Cargo.lock v4 requires Rust 1.78+ |
There was a problem hiding this comment.
The min parameter is set to 1.78.0, but the actual MSRV documented in the codebase is 1.87.0 (see line 41 in this file, Makefile line 47, and docs/docs/running-juno.md). Setting min to 1.78.0 could mask issues if the actual MSRV regresses to a version between 1.78.0 and 1.87.0. Consider setting min to match the current MSRV of 1.87.0 instead, or document why 1.78.0 is the appropriate floor if there's a specific technical reason.
| min: "1.78.0" # Cargo.lock v4 requires Rust 1.78+ | |
| min: "1.87.0" # Cargo.lock v4 requires Rust 1.78+ |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3373 +/- ##
==========================================
+ Coverage 76.19% 76.23% +0.03%
==========================================
Files 351 351
Lines 33366 33366
==========================================
+ Hits 25423 25435 +12
+ Misses 6127 6121 -6
+ Partials 1816 1810 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
No description provided.