feat(rpcv10): response_flags for the rpcv10; proof_facts, proof for invoke v3 txs#3380
Open
MaksymMalicki wants to merge 13 commits intomainfrom
Open
feat(rpcv10): response_flags for the rpcv10; proof_facts, proof for invoke v3 txs#3380MaksymMalicki wants to merge 13 commits intomainfrom
response_flags for the rpcv10; proof_facts, proof for invoke v3 txs#3380MaksymMalicki wants to merge 13 commits intomainfrom
Conversation
MaksymMalicki
temporarily deployed
to
Development
GitHub Actions
Inactive
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (49.15%) is below the target coverage (60.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #3380 +/- ##
==========================================
- Coverage 76.20% 75.69% -0.51%
==========================================
Files 351 378 +27
Lines 33366 34932 +1566
==========================================
+ Hits 25425 26443 +1018
- Misses 6126 6626 +500
- Partials 1815 1863 +48 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rodrodros
reviewed
Jan 20, 2026
MaksymMalicki
temporarily deployed
to
Development
GitHub Actions
Inactive
MaksymMalicki
temporarily deployed
to
Development
GitHub Actions
Inactive
MaksymMalicki
temporarily deployed
to
Development
GitHub Actions
Inactive
MaksymMalicki
temporarily deployed
to
Development
GitHub Actions
Inactive
MaksymMalicki
temporarily deployed
to
Development
GitHub Actions
Inactive
MaksymMalicki
had a problem deploying
to
Development
GitHub Actions
Failure
MaksymMalicki
had a problem deploying
to
Development
GitHub Actions
Failure
MaksymMalicki
had a problem deploying
to
Development
GitHub Actions
Failure
MaksymMalicki
had a problem deploying
to
Development
GitHub Actions
Failure
MaksymMalicki
had a problem deploying
to
Development
GitHub Actions
Failure
MaksymMalicki
had a problem deploying
to
Development
GitHub Actions
Failure
EgeCaner
reviewed
Feb 3, 2026
| ContractClass: v9Tx.ContractClass, | ||
| } | ||
|
|
||
| if v9Tx.Transaction.Type == rpcv9.TxnInvoke && isVersion3(v9Tx.Transaction.Version) { |
Contributor
There was a problem hiding this comment.
Can we move this to adaptRpcTxToFeederTx
| return starknet.DataAvailabilityMode(*mode) | ||
| } | ||
|
|
||
| func adaptRPCTxToFeederTx(rpcTx *rpcv9.Transaction) starknet.Transaction { |
Contributor
There was a problem hiding this comment.
Why not receive rpcv10.Transaction and also handle proof here
MaksymMalicki
temporarily deployed
to
Development
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces support for new optional fields for transactions:
proof_factsfor invoke v3 transactionsproofandproof_factsfor broadcasted invoke v3 transactions, which are passed to the gateway write APIThe invoke v3 transactions will contain
proof_factsoptional field, when theINCLUDE_PROOF_FACTSflag is included in theresponse_flagsnew parameter instarknet_getBlockWithTxs,starknet_getBlockWithReceipts,starknet_getTransactionByHash,starknet_getTransactionByBlockIdAndIndex. If the flag is not present, the transactions are processed in the same way as in previous versions of the RPC.