feat(rpcv10): initial reads for starknet_traceBlockTransactions and starknet_simulateTransactions#3384
Open
MaksymMalicki wants to merge 9 commits intomainfrom
Open
feat(rpcv10): initial reads for starknet_traceBlockTransactions and starknet_simulateTransactions#3384MaksymMalicki wants to merge 9 commits intomainfrom
starknet_traceBlockTransactions and starknet_simulateTransactions#3384MaksymMalicki wants to merge 9 commits intomainfrom
Conversation
Contributor
|
Minimum supported Rust version is |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3384 +/- ##
==========================================
+ Coverage 75.68% 75.71% +0.02%
==========================================
Files 361 369 +8
Lines 34024 34437 +413
==========================================
+ Hits 25752 26073 +321
- Misses 6443 6519 +76
- Partials 1829 1845 +16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces support for the new
initial_readsoptional field for thestarknet_traceBlockTransactionsandstarknet_simulateTransactions.Changes:
RETURN_INITIAL_READSflag to the simulation flags. If theRETURN_INITIAL_READSis included in thesimulation_flagsofstarknet_simulateTransactions, theinitial_readsfield will be added to the response.trace_flagstostarknet_traceBlockTransactions. If theRETURN_INITIAL_READSflag is included, theinitial_readsfield will be added to the response.starknet_traceBlockTransactionsandstarknet_simulateTransactions, if theRETURN_INITIAL_READSwas not included in the flags set, the response looks the same as in previous versions of the RPC (list of transaction simulations / transaction traces)RETURN_INITIAL_READSwas passed tostarknet_traceBlockTransactions, the response format is different. It contains two fields:traces(list of transaction traces for this block) andinitial_reads(aggregated initial reads for all the traced transactions)RETURN_INITIAL_READSwas passed tostarknet_simulateTransactions, the response format is different. It contains two fields:simulated_transactions(list of transaction simulations) andinitial_reads(aggregated initial reads for all the simulated transactions)NOTE:
If the
initial_readsare requested, but they don't exist (i. e. older blocks, where the traces are fetched from the gateway), they are not included in the response.This PR required bumping the blockifier to newer version.