feature: Add support for block validation (flashbots_validateBuilderSubmissionV3) #7335
+997
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjnrohit
force-pushed
the
feature/flashbots_endpoints
branch
from
cbd73ae
to
9eb6f70
Compare
LukaszRozmej
requested changes
Sep 9, 2024
src/Nethermind/Nethermind.Consensus/Processing/ReadOnlyTxProcessingEnv.cs
Outdated
Show resolved
Hide resolved
src/Nethermind/Nethermind.BlockValidation/IFlashbotsRpcModule.cs
Outdated
Show resolved
Hide resolved
src/Nethermind/Nethermind.BlockValidation/Handlers/ValidateBuilderSubmissionHandler.cs
Outdated
Show resolved
Hide resolved
src/Nethermind/Nethermind.BlockValidation/Handlers/ValidateBuilderSubmissionHandler.cs
Outdated
Show resolved
Hide resolved
Comment on lines
126
to
130
| if (!_blockTree.IsBetterThanHead(block.Header)) | ||
| { | ||
| error = $"Block {block.Header.Hash} is not better than head"; | ||
| return false; | ||
| } |
There was a problem hiding this comment.
We can validate only on future blocks?
There was a problem hiding this comment.
src/Nethermind/Nethermind.BlockValidation/Handlers/ValidateBuilderSubmissionHandler.cs
Outdated
Show resolved
Hide resolved
src/Nethermind/Nethermind.BlockValidation/Handlers/ValidateBuilderSubmissionHandler.cs
Outdated
Show resolved
Hide resolved
Comment on lines
322
to
326
| if (block is not null && !ValidateBlobsBundle(block.Transactions, blobsBundle, out string? blobsError)) | ||
| { | ||
| if (_logger.IsWarn) _logger.Warn($"Invalid blobs bundle. Result of {payloadStr}. Error: {blobsError}"); | ||
| return BlockValidationResult.Invalid(blobsError ?? "Blobs bundle validation failed"); | ||
| } |
There was a problem hiding this comment.
A but weird that we do validations after processing a block, shouldn't we do it first? (It would be less costly)
There was a problem hiding this comment.
I followed the same order as they did, but yeah I agree doing this way would be costly
There was a problem hiding this comment.
W should consider changing it later, maybe @Ruteri knows why this is the order of checks?
Co-authored-by: LukaszRozmej <[email protected]>
Co-authored-by: MarekM25 <[email protected]> Co-authored-by: Ahmad Bitar <[email protected]>
Co-authored-by: lukasz.rozmej <[email protected]> Co-authored-by: Marcin Sobczak <[email protected]>
Co-authored-by: Lukasz Rozmej <[email protected]> Co-authored-by: Jorge Mederos <[email protected]>
rjnrohit
force-pushed
the
feature/flashbots_endpoints
branch
from
afc3ecd
to
4eeeb9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7462
This PR aims to implement flashbots endpoint (
flashbots_validateBuilderSubmissionV3) ref: https://github.com/flashbots/builder/blob/df9c765067d57ab4b2d0ad39dbb156cbe4965778/eth/block-validation/api.go#L225-L246block,blobsand verifies if theParentHash,BlockHash,GasLimit, andGasUsedin the params.Message match the sent payload and produce an error otherwise.Changes
It introduces a new
JsonRpcplugin calledNethermind.Flashbotswhich implements a new endpoint calledflashbots_validateBuilderSubmissionV3Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Notes on testing
I'll write the tests once I'm done with manual testing