Add information on taking up issues. #7854
Conversation
obasekiosa
requested review from
rubo,
LukaszRozmej and
MarekM25
as code owners
|
@rubo |
| #### Meets [contribution](../CONTRIBUTING.md) and [code of conduct](../CODE_OF_CONDUCT.md) guidelines | ||
| - [ ] Yes | ||
| - [ ] No | ||
|
|
There was a problem hiding this comment.
Yet another set of checkboxes. Even our team doesn't fill these. People will ignore it. I can't see someone submitting a PR and checking "No" for meeting contributing guidelines and the code of conduct.
Maybe we can modify the start text to mention contributing guide as follows:
Please choose one of the keywords above to refer to the issue this PR solves, followed by the issue number (e.g., Fixes #000). If no issue number, remove the line. Also, remove everything marked optional that is not applicable. Please read and follow our contributing guidelines. Remove this note after reading.
We already have this in README as well.
There was a problem hiding this comment.
true will remove. this.
| Note: Before attempting and issue please go through the [contribution guidelines](../../CONTRIBUTING.md) and | ||
| [code of conduct page](../../CODE_OF_CONDUCT.md) especially | ||
| the [section about attempting an issue](../../CONTRIBUTING.md#attempting-an-issue) and the [do's and don't's](../../CONTRIBUTING.md#dos-and-donts). | ||
|
|
||
|
|
There was a problem hiding this comment.
not necessarily the case this isn't for the internal team tbh.
Its for anyone saying "hi I want to take an issue".
This way no one says that because they read it.
But We could reduce it to just the attempting an issue page.
| Note: Before attempting and issue please go through the [contribution guidelines](../../CONTRIBUTING.md) and | ||
| [code of conduct page](../../CODE_OF_CONDUCT.md) especially | ||
| the [section about attempting an issue](../../CONTRIBUTING.md#attempting-an-issue) and the [do's and don't's](../../CONTRIBUTING.md#dos-and-donts). | ||
|
|
||
|
|
There was a problem hiding this comment.
I don't see any problems with submitting issues. Why do we need to stress this here?
There was a problem hiding this comment.
this shows up on a summit-ed issue. It's not a guide line for submitting issues but for taking an issue up.
Same resolution as i said above.
| ### Attempting an issue | ||
| Feel free to pick up any **unassigned** issue from the issues page to work on. | ||
| You can begin working on an issue by asking clearifying questions on the specific issues page or by | ||
| submit a pull request linking to the issue even if just a simple draft to indicate you are working on the issue. | ||
| The pull request would be reviewed and merged if it passes the review or more changes would be requested. | ||
| Note: Submitting a pull request does not imply the requested changes would be merged they could be completely rejected. | ||
|
|
There was a problem hiding this comment.
I'm not sure we're okay with any unassigned issues being picked up by 3rd parties. It depends.
There was a problem hiding this comment.
Ok true, easy fix just - Just the ones marked as "help wanted".
Changes
Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Documentation
Requires documentation update
Requires explanation in Release Notes