Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v2 Implement EIP-7623: Increase calldata cost #7859

Open
wants to merge 29 commits into
base: master
Choose a base branch
from
Open

v2 Implement EIP-7623: Increase calldata cost #7859

wants to merge 29 commits into from

Conversation

tanishqjasoria
Copy link
Contributor

Resolves #7527

https://eips.ethereum.org/EIPS/eip-7623

Changes

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Notes on testing

Optional. Remove if not applicable.

Documentation

Requires documentation update

  • Yes
  • No

If yes, link the PR to the docs update or the issue with the details labeled docs. Remove if not applicable.

Requires explanation in Release Notes

  • Yes
  • No

If yes, fill in the details here. Remove if not applicable.

Remarks

Optional. Remove if not applicable.

@tanishqjasoria tanishqjasoria mentioned this pull request Dec 4, 2024
Closed
16 tasks
@tanishqjasoria tanishqjasoria requested a review from ak88 December 4, 2024 08:57
ak88

This comment was marked as resolved.

Sign in to view

LukaszRozmej
LukaszRozmej requested changes Dec 5, 2024
View reviewed changes
Copy link
Member

@LukaszRozmej LukaszRozmej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing super major, but some code quality changes and potential 1 issue with access list

src/Nethermind/Nethermind.Evm/IntrinsicGasCalculator.cs Outdated Show resolved Hide resolved
src/Nethermind/Nethermind.Evm.Test/Eip2028Tests.cs Outdated Show resolved Hide resolved
src/Nethermind/Nethermind.Evm.Test/IntrinsicGasCalculatorTests.cs Outdated Show resolved Hide resolved
src/Nethermind/Nethermind.Evm.Test/IntrinsicGasCalculatorTests.cs Outdated Show resolved Hide resolved
src/Nethermind/Nethermind.Evm/IntrinsicGasCalculator.cs Outdated Show resolved Hide resolved
src/Nethermind/Nethermind.JsonRpc/Modules/Eth/EthRpcModule.TransactionExecutor.cs Outdated Show resolved Hide resolved
ak88
ak88 reviewed Dec 6, 2024
View reviewed changes
Copy link
Contributor

@ak88 ak88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some cosmetic stuff. Could also be worth refactoring some methods like ExecuteEvmCall to not use so many out parameters

src/Nethermind/Nethermind.Evm/TransactionProcessing/TransactionProcessor.cs Outdated Show resolved Hide resolved
src/Nethermind/Nethermind.Evm/TransactionProcessing/TransactionProcessor.cs Show resolved Hide resolved
src/Nethermind/Nethermind.Evm/IntrinsicGasCalculator.cs Outdated Show resolved Hide resolved
@tanishqjasoria tanishqjasoria requested a review from ak88 December 17, 2024 08:53
ak88
ak88 approved these changes Dec 17, 2024
View reviewed changes
src/Nethermind/Nethermind.Evm/IntrinsicGasCalculator.cs

namespace Nethermind.Evm;


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add some comment why the class is here and link to the EIP.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i am not sure if that is neede. i think it is self explanatory - there are no comments and descriptions for other gas calculations as well
i can maybe add a reference to eip7623 for floor gas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChanHongMing ChanHongMing ChanHongMing left review comments

@LukaszRozmej LukaszRozmej LukaszRozmej approved these changes

@ak88 ak88 ak88 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement EIP-7623 Increase calldata cost
4 participants
@tanishqjasoria @ak88 @LukaszRozmej @ChanHongMing