v2 Implement EIP-7623: Increase calldata cost#7859
Merged
smartprogrammer93 merged 30 commits intomasterfrom Jan 4, 2025
Merged
v2 Implement EIP-7623: Increase calldata cost#7859smartprogrammer93 merged 30 commits intomasterfrom
smartprogrammer93 merged 30 commits intomasterfrom
Conversation
16 tasks
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
LukaszRozmej
requested changes
Dec 5, 2024
Member
LukaszRozmej
left a comment
LukaszRozmej
left a comment
There was a problem hiding this comment.
Nothing super major, but some code quality changes and potential 1 issue with access list
src/Nethermind/Nethermind.Evm.Test/IntrinsicGasCalculatorTests.cs
Outdated
Show resolved
Hide resolved
src/Nethermind/Nethermind.Evm.Test/IntrinsicGasCalculatorTests.cs
Outdated
Show resolved
Hide resolved
src/Nethermind/Nethermind.JsonRpc/Modules/Eth/EthRpcModule.TransactionExecutor.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Lukasz Rozmej <lukasz.rozmej@gmail.com>
ak88
reviewed
Dec 6, 2024
Contributor
ak88
left a comment
ak88
left a comment
There was a problem hiding this comment.
Some cosmetic stuff. Could also be worth refactoring some methods like ExecuteEvmCall to not use so many out parameters
src/Nethermind/Nethermind.Evm/TransactionProcessing/TransactionProcessor.cs
Outdated
Show resolved
Hide resolved
src/Nethermind/Nethermind.Evm/TransactionProcessing/TransactionProcessor.cs
Show resolved
Hide resolved
Co-authored-by: ak88 <anders@nethermind.io>
LukaszRozmej
approved these changes
Dec 17, 2024
ak88
approved these changes
Dec 17, 2024
|
|
||
| namespace Nethermind.Evm; | ||
|
|
||
|
|
Contributor
There was a problem hiding this comment.
Add some comment why the class is here and link to the EIP.
Contributor
Author
There was a problem hiding this comment.
i am not sure if that is neede. i think it is self explanatory - there are no comments and descriptions for other gas calculations as well
i can maybe add a reference to eip7623 for floor gas
Co-authored-by: lukasz.rozmej <lukasz.rozmej@gmail.com>
LukaszRozmej
approved these changes
Dec 18, 2024
16 tasks
rjnrohit
pushed a commit
that referenced
this pull request
Jan 11, 2025
Co-authored-by: Lukasz Rozmej <lukasz.rozmej@gmail.com> Co-authored-by: ak88 <anders@nethermind.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #7527
https://eips.ethereum.org/EIPS/eip-7623
Changes
Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Notes on testing
Optional. Remove if not applicable.
Documentation
Requires documentation update
If yes, link the PR to the docs update or the issue with the details labeled
docs. Remove if not applicable.Requires explanation in Release Notes
If yes, fill in the details here. Remove if not applicable.
Remarks
Optional. Remove if not applicable.