Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check async killing for less errors on shutdown #7933

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

kamilchodola
Copy link
Contributor

Using async methods to have few seconds more for post-action cleanup.

Right now we remove VM early right after sync executed - but because Vm is also a runner we can hit a Collison that VM got removed before action cleanup properly so that's why we send the removal request async now to give it more room for this.

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

@kamilchodola kamilchodola requested review from rubo and a team as code owners December 18, 2024 17:13
@kamilchodola kamilchodola merged commit 521084a into master Dec 19, 2024
88 of 89 checks passed
@kamilchodola kamilchodola deleted the kch/check_async_kill branch December 19, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants