feat: standardized error responses for payload validation

[merklefruit]

Fixes #7901

Changes

• Added more descriptive payload validation error responses in engine API

Types of changes

What types of changes does your code introduce?

• Optimization

Testing

Requires testing

• Yes
• No

Documentation

Requires documentation update

• Yes
• No

Remarks

More context on this change can be found in #7901

[merklefruit]

Hi @MarekM25, can I help add context for a review? Would love to see this merged if possible

[LukaszRozmej]

@kamilchodola It would be good to run engine and pyspec hive tests on this PR. But I cannot seem to run them on outside branches from actions.

[MarekM25]

LGTM, but Hive tests will have to be updated to handle new error codes

[merklefruit]

@MarekM25 I can do that, can you provide a quick pointer to where i should look?

[MarekM25]

Quote reply

I think you will have to search for either our old errors or geth errors in this repo and provide a PR: https://github.com/ethereum/hive here

I can contact you with maintainers if needed. Thx for your contribution! 🙏

[merklefruit]

@MarekM25 hi, I've been able to run the ethereum/engine hive test suite for both this branch and nethermind's master.
Here are the results:

• http://135.181.191.125:8081/ here is the result on the latest nethermind master branch
• http://135.181.191.125:8082/ here is the result on my PR's branch

from this run, it seems like this specific branch is not causing any new errors, but as I previously mentioned I'm not familiar enough with Hive to be 100% sure that I didn't miss something.

I have also tried to look for the hardcoded error messages in the hive codebase but haven't found them: the behaviour there seems to be to only check the "Status: Invalid" property, and not the actual validation error message

edit: I also ran the ethereum/eest suite on this branch, results are available here: http://remotebeast:8083/

[benaadams]

@merklefruit thank you for your contribution