Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set minimum state pivot to be at least the block after #7949

Merged

Conversation

asdacap
Copy link
Contributor

@asdacap asdacap commented Dec 21, 2024

  • Should fix chiado missing state issue when using fuzzer.
  • This happens when the persisted state is equal to the sync pivot which on restart causes the start block to be equal to the persisted state block which is a problem as the block may not get downloaded in non validator mode. This can be seen with this log lone 2024-12-20 12:58:13.4925|INFO|Blockchain.BlockTree|16|Start block loaded from reorg boundary - 13411836 - where the persisted block is null.
  • This set the state pivot to be at least sync pivot + 1.

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

@asdacap asdacap merged commit b81070d into master Dec 24, 2024
79 checks passed
@asdacap asdacap deleted the fix/missing-state-root-when-statesync-is-equal-syncpivot branch December 24, 2024 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants