Merged
Conversation
LukaszRozmej
approved these changes
Dec 30, 2024
Comment on lines
+147
to
+151
| public ResultWrapper<string> admin_verifyTrie() | ||
| { | ||
| if (_blockTree.Head is null) | ||
| { | ||
| return ResultWrapper<string>.Fail("Head is null. Unable to know state root to verify."); |
Member
There was a problem hiding this comment.
Potentially can we pass the BlockParameter where we want to verify tries?
Also potentially should we add admin_availableStateRoots, where it would look-up where state root is available in some block range?
| _logger.Error($"Error in verify trie", e); | ||
| } | ||
|
|
||
| }, TaskCreationOptions.LongRunning); |
Member
There was a problem hiding this comment.
I remember we were removing LongRunning because of some reason, @benaadams ?
| { | ||
| if (_blockTree.Head is null) | ||
| SearchResult<BlockHeader> headerSearchResult = _blockTree.SearchForHeader(block); | ||
| if (headerSearchResult.Object is null) |
Member
There was a problem hiding this comment.
I think we need a check if state root is available?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
admin_verifyTrieRPC.Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Notes on testing