Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EIP7623 - account for floor gas after substracting refunds #8038

Merged
merged 5 commits into from
Jan 15, 2025

Conversation

tanishqjasoria
Copy link
Contributor

@tanishqjasoria tanishqjasoria commented Jan 10, 2025

ref: ethereum/EIPs#9227

Changes

  • first substract the refunds and then account for floor gas

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Notes on testing

Optional. Remove if not applicable.

Documentation

Requires documentation update

  • Yes
  • No

If yes, link the PR to the docs update or the issue with the details labeled docs. Remove if not applicable.

Requires explanation in Release Notes

  • Yes
  • No

If yes, fill in the details here. Remove if not applicable.

Remarks

Optional. Remove if not applicable.

@tanishqjasoria tanishqjasoria changed the title EIP7623 - Account for floor gas after substracting refunds EIP7623 - account for floor gas after substracting refunds Jan 10, 2025
@tanishqjasoria tanishqjasoria marked this pull request as ready for review January 10, 2025 05:36
@tanishqjasoria tanishqjasoria merged commit c5f6fe8 into master Jan 15, 2025
79 checks passed
@tanishqjasoria tanishqjasoria deleted the eip-7623-update branch January 15, 2025 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants